When i was a little kid, one of my cousins told me to clean my coin collection (only a hundred of coins those days), putting them in vinegar for a month! All of them together: coppers, copper-nickels, nickels, irons etc. A total disaster for my little collection. A layer of "dirt" has covered all my coins and also their shiny lustre has gone! This was a good lesson for me.
Today i decided to try cleaning some of them using electrolysis (12 V/with soda). I also make a "test" in some silvers. The result is good. Here is one of my childhood's collection.